perf: Skip updating registry if signature has not changed#3779
Merged
FrederikBolding merged 3 commits intomainfrom Dec 17, 2025
Merged
perf: Skip updating registry if signature has not changed#3779FrederikBolding merged 3 commits intomainfrom
FrederikBolding merged 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3779 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 420 420
Lines 12019 12032 +13
Branches 1872 1874 +2
=======================================
+ Hits 11819 11832 +13
Misses 200 200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since verifying and updating the registry can be expensive on slower devices, we can store the current signature and only re-verify when the signature changes.
Note
Stores and persists the registry signature to skip verification and database updates when unchanged, updating controller logic and tests.
json.ts):signaturetoSnapsRegistryStateand controller metadata (persisted, logged; not exposed to UI).registry.jsonandsignature.json, parse signature; ifsignaturematches state, skip verification/update and only refreshlastUpdated/databaseUnavailable.SignatureStructand persist newdatabaseandsignature.#verifySignatureto acceptSignatureStruct(using@metamask/superstructInfer).json.test.ts):signature.@metamask/superstruct.Written by Cursor Bugbot for commit 8ff96dd. This will update automatically on new commits. Configure here.